fix(config): set default_builder_enabled to true by default (#1639)#1730
Closed
potb wants to merge 2 commits intocode-yeongyu:devfrom
Closed
fix(config): set default_builder_enabled to true by default (#1639)#1730potb wants to merge 2 commits intocode-yeongyu:devfrom
potb wants to merge 2 commits intocode-yeongyu:devfrom
Conversation
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Logic change from false to true default for default_builder_enabled is a behavioral change that could affect existing users. Cannot be 100% sure no regressions without knowing full impact of_en`
Add 3 BDD tests covering: - Default (undefined) registers OpenCode-Builder - Explicit false disables OpenCode-Builder - Sisyphus disabled prevents OpenCode-Builder registration These tests verify the default behavior before implementation change.
…ngyu#1639) Changed default for default_builder_enabled from false to true. OpenCode-Builder agent now registers by default when Sisyphus is enabled, allowing users to leverage the builder agent without explicit configuration. Closes code-yeongyu#1639
42db43c to
e6bf9ec
Compare
Contributor
Author
|
Closing — the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1639
default_builder_enableddefaults tofalse, so OpenCode-Builder never registers unless explicitly opted in. Should betrue.One-line fix (
?? false→?? true) + tests.